Skip to content

[CLIENT-3752] Add support for path expressions and operations #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Parent: FF to Dev
wants to merge 124 commits into
base: dev
Choose a base branch
from
Open

[CLIENT-3752] Add support for path expressions and operations #847

wants to merge 124 commits into from

Conversation

@juliannguyen4
Copy link
Collaborator

@juliannguyen4 juliannguyen4 commented Oct 6, 2025 •
edited
Loading

Known Issues

Missing expression that exposes as_exp_result_remove() from the C client

Extra changes

  • Refactor conversion code for as_cdt_ctx

Docs

Contexts

Both contexts

Operations

select_by_path
modify_by_path

Expressions

LoopVar*

Flags for new operations and expressions

CDT Select Flags

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 82.48848% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.37%. Comparing base (34c2e3f) to head (9c15c37).
⚠️ Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/conversions.c 77.65% 21 Missing ⚠️
src/main/client/operate.c 75.51% 12 Missing ⚠️
src/main/convert_expressions.c 86.84% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #847      +/-   ##
==========================================
+ Coverage   82.35%   82.37%   +0.01%     
==========================================
  Files          99       99              
  Lines       14379    14508     +129     
==========================================
+ Hits        11842    11951     +109     
- Misses       2537     2557      +20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliannguyen4
get latest c cl
fa886c2
@juliannguyen4
Add operate.cdt_select() test case
c5c0c37
@juliannguyen4
WIP operations.cdt_select() implementation. flags not supported yet
88ce202
@juliannguyen4
Workaround: surround type hint with quotes to prevent circular refere…
3b2e957 
…nces
@juliannguyen4
rm culprit import
721e4de
@juliannguyen4
First rough draft implementation of operation cdt_apply(). negative p…
2fa4647 
…ath not done
@juliannguyen4
prefix with underscore to mark constants as private
61dd90c
@juliannguyen4
prefix pyobject var name with py_ to make easier to read
9519804
@juliannguyen4
rm dup definition
93fadc3
@juliannguyen4
Revert "rm dup definition"
137707d 
This reverts commit 93fadc3.
@juliannguyen4
Revert "prefix pyobject var name with py_ to make easier to read"
0349bf4 
This reverts commit 9519804.
@juliannguyen4
Merge remote-tracking branch 'origin/dev' into CLIENT-3752-path-expre…
0be5f8e 
…ssions
@juliannguyen4
implement as_cdt_select_flags
482543f
@juliannguyen4
fix macro
2ad1734
@juliannguyen4
fix
94dbae0
@juliannguyen4
Add some of the missing stubs
ce91188
@juliannguyen4
Op id 3 is now valid. fix test
eaee895
@juliannguyen4
Document cdt select flags
e4d3df9
@juliannguyen4
make less ambiguous
1407c76
@juliannguyen4
Move outside of if block
7774423
@juliannguyen4
Implement cdt_select ctx
e0f890d
@juliannguyen4
finish test for cdt_select operation
6fd8036
@juliannguyen4
Fix test and code. need to run against server rc
c9ee120
@juliannguyen4
Follow prd examples
4abaf19
@juliannguyen4
fix test case
f498bf8
@juliannguyen4
Add neg test case
217010a
@juliannguyen4
Stub for testing cdt select flags
7618495
@juliannguyen4
Move test cases to separate file because the patch is already large e…
5679f37 
…nough.
@juliannguyen4
Fix cdt modify expr test
f74d3c7
@juliannguyen4
Finish loopvar id enum tests
6f53e1b
@juliannguyen4
Add neg test for empty ctx list passed to modify op
6ce81da
@juliannguyen4
Add neg test for ctx=None. code should be able to handle invalid pyth…
5934797 
…on types
@juliannguyen4
finish documentation.
963d196
@juliannguyen4
try adding reference to type in param docstring. not letting me click…
2a6e37c 
… cdt_ctx in func signature
@juliannguyen4
fully qualified name
b7868a8
@juliannguyen4
Revert "fully qualified name"
465bedf 
This reverts commit b7868a8.
@juliannguyen4
dont need since func signature already has
091147b
@juliannguyen4
Keyword was changed to make more readable
ad93161
@juliannguyen4
Rm outdated TODOs
a16dabf
@juliannguyen4
Fix four failing tests...
ac603dd
@juliannguyen4
fix spelling
cf7eaf9
@juliannguyen4
fix mem leak
fb61fac
@juliannguyen4
pointer to struct, not struct ref
18665b2
@juliannguyen4
most clear
66de999
@juliannguyen4
Only 'bottom' number of as_exp_entry entries are actually initialized…
5d34c87 
…. more memory is being allocated than needed
@juliannguyen4
rm todo for now
a1d4d20
@juliannguyen4
Make LoopVar public so we can see the init documentation for inheriti…
52b125b 
…ng classes
@juliannguyen4
Show that LoopVar* classes are subclasses of LoopVar class
f6895f9
@juliannguyen4
Remove type annotation for expr since it gets expanded in the docs
1e2d5c2
@juliannguyen4
Make name shorter since the file name is self-explanatory
a157ae1
@juliannguyen4
fix confusing comment
39d6632
@juliannguyen4
Clear up why test set up this way
e166f24
@juliannguyen4
confusing spacing
a84e307
@juliannguyen4
bad spacing
91cbccc
@juliannguyen4
improve var name
9c15c37
@juliannguyen4 juliannguyen4 marked this pull request as ready for review October 24, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DomPeliniAerospike DomPeliniAerospike Awaiting requested review from DomPeliniAerospike

@dwelch-spike dwelch-spike Awaiting requested review from dwelch-spike

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@juliannguyen4 @codecov-commenter